ci: remove redundant compile step on non-Linux runners#382
Merged
askpt merged 1 commit intoJun 19, 2026
Merged
Conversation
test:unit already runs `npm run compile` internally before invoking mocha. The standalone `npm run compile` step that preceded it on non-Linux runners was therefore compiling TypeScript twice per CI run, wasting 2-3 seconds on macOS and Windows. Remove the redundant step. test:unit still compiles before running mocha, so any TypeScript errors surface at the same point in the pipeline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
Coverage 73.72% 73.72%
=======================================
Files 13 13
Lines 4133 4133
Branches 434 434
=======================================
Hits 3047 3047
Misses 1084 1084
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the CI workflow for macOS and Windows runners by removing a redundant TypeScript compilation step. Since npm run test:unit already runs npm run compile first, this avoids compiling twice on non-Linux platforms while preserving the same failure point for TypeScript errors.
Changes:
- Removed the standalone
npm run compilestep on non-Linux runners in CI. - Updated the workflow comments to reflect that
test:unitalready performs compilation and that lint remains Linux-only viatest:coverage.
askpt
deleted the
repo-assist/eng-ci-remove-redundant-compile-20260618-ba83317769e2da39
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test:unit already runs
npm run compileinternally before invoking mocha.The standalone
npm run compilestep that preceded it on non-Linux runnerswas therefore compiling TypeScript twice per CI run, wasting 2-3 seconds on
macOS and Windows.
Remove the redundant step. test:unit still compiles before running mocha, so
any TypeScript errors surface at the same point in the pipeline.
Closes #380
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com