asterisk_testsuite: Fixed Replaced SIPp -mp with -min_rtp_port PR25#141
Open
AlexisHadj wants to merge 1 commit into
Open
asterisk_testsuite: Fixed Replaced SIPp -mp with -min_rtp_port PR25#141AlexisHadj wants to merge 1 commit into
AlexisHadj wants to merge 1 commit into
Conversation
Added the following requirements recommended in PR 25: 1. Reverted the yaml files to specifying -mp 2. Check the version to see which option -mp or -min_rtp_port is supported by that version and set the default to it. 3. Check the arguments passed by the iterator and replace occurrences of those options with the ones valid for the sipp version.
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Workflow Check completed successfully |
Contributor
Author
|
cherry-pick-to: 20 |
gtjoseph
dismissed
github-actions[bot]’s stale review
Pull Request Checklist Complete
Member
|
So this PR replaces #25 right? I can close that PR? |
Contributor
Author
I believe you can close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following requirements recommended in PR 25: