Conversation
ying2212
marked this pull request as draft
July 14, 2026 18:01
Collaborator
Author
|
Draft:
|
ingest_spectrum already handles duplicate detection internally. Simplify skip-reason tracking and update docs/evals to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new skill
astrodb-ingest-spectra/to generate and run scripts for ingesting spectra usingastrodb_utils.spectra.ingest_spectrumAddress #26
Includes:
references/ingest_spectrum_api.md— API signatures and warnings for spectrum helpersscripts/ingest_spectra.py— reference template (generated scripts are saved toastrodb-ingest-artifacts/)evals/evals.json— 7 evaluate cases based on BONES archive dataKey Behaviors
check_spectrum_plottableandfind_spectrabefore ingestion to validate theSpectracomposite key:source,regime,mode,obs_date, andreferenceobs_dateare flagged and reported instead of guessed,since it's part of the primary key and can't be null