feat: improve TSC page design to display all repos maintained by an individual for better visibility and transparency#5606
Open
princerajpoot20 wants to merge 8 commits into
Conversation
princerajpoot20
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds clickable repo pills with expand/collapse, an ambassador badge and filter on the TSC page, updates pagination chevron usage, and adds Cypress coverage for the new interactions. ChangesTSC Ambassador Filter and Repo Expand/Collapse
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5606--asyncapi-website.netlify.app/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5606 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 931 931
Branches 180 180
=========================================
Hits 931 931 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
components/community/TSCMemberCard.tsx (1)
84-103: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAdd
aria-expandedto the repo expand/collapse controls.The expand (
+N) and "Show less" buttons toggle visible content but expose no state to assistive tech. Addingaria-expandedimproves screen-reader usability.♿ Suggested change
<button onClick={() => setShowAllRepos(true)} data-testid='repo-expand-button' + aria-expanded={false} className='inline-flex items-center gap-1 px-3 py-1 rounded-full text-xs font-medium bg-gray-100 dark:bg-gray-800 text-gray-600 dark:text-gray-400 hover:bg-gray-200 dark:hover:bg-gray-700 cursor-pointer transition-colors' > +{hiddenCount} <IconChevronDown className='w-3 h-3' /> </button><button onClick={() => setShowAllRepos(false)} data-testid='repo-collapse-button' + aria-expanded={true} className='inline-flex items-center gap-1 px-3 py-1 rounded-full text-xs font-medium bg-gray-100 dark:bg-gray-800 text-gray-500 dark:text-gray-400 hover:bg-gray-200 dark:hover:bg-gray-700 cursor-pointer transition-colors' > Show less <IconChevronUp className='w-3 h-3' /> </button>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@components/community/TSCMemberCard.tsx` around lines 84 - 103, The repo toggle controls in TSCMemberCard currently change the visible repos without exposing their open/closed state to assistive tech. Update both buttons in the showAllRepos / hiddenCount branches to include aria-expanded, using the current showAllRepos state so the +N expand control and the Show less collapse control each announce their expanded state correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cypress/pages/tscpage.js`:
- Around line 50-65: The `expandRepos` helper in `TSCPage` leaves the member
search field populated, which can leak filtered state into later tests. Update
`expandRepos` to clean up after itself by clearing the search input once the
repo expand action is complete, or make the surrounding Cypress flow
self-contained by resetting the search in test setup/teardown; keep
`collapseRepos` working by ensuring the member card remains discoverable after
`expandRepos` is used.
In `@cypress/tscpage.cy.js`:
- Around line 87-98: The expandRepos spec leaves the TSC page search filter
active after expanding “Aishat Muibudeen,” which can leak state into later
tests. Update the test in cypress/tscpage.cy.js to clear the search input after
the assertions, using the same search field selector already used elsewhere.
Keep the fix localized to the expand spec and rely on tscPage.expandRepos plus
the existing h3/repo-pill checks.
In `@pages/community/tsc.tsx`:
- Line 18: The ambassador GitHub matching in tsc.tsx is case-sensitive, so users
can be missed when the handles differ only by letter casing. Normalize the
values when building ambassadorGitHubHandles from ambassadorsList and when
checking member.github in both the filter and the isAmbassador prop so
comparisons use the same case-insensitive form. Update the lookups around
ambassadorGitHubHandles, the member filter, and the isAmbassador usage to
consistently compare normalized GitHub usernames.
---
Nitpick comments:
In `@components/community/TSCMemberCard.tsx`:
- Around line 84-103: The repo toggle controls in TSCMemberCard currently change
the visible repos without exposing their open/closed state to assistive tech.
Update both buttons in the showAllRepos / hiddenCount branches to include
aria-expanded, using the current showAllRepos state so the +N expand control and
the Show less collapse control each announce their expanded state correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 84b982ed-162b-4b89-9379-5421db98e961
📒 Files selected for processing (6)
components/community/TSCMemberCard.tsxcomponents/icons/ChevronDown.tsxcomponents/icons/ChevronUp.tsxcypress/pages/tscpage.jscypress/tscpage.cy.jspages/community/tsc.tsx
|
Mayaleeeee
reviewed
Jul 2, 2026
Mayaleeeee
left a comment
Mayaleeeee
left a comment
Member
There was a problem hiding this comment.
Hi @princerajpoot20 thanks for working on this. I love the idea.
Here is my review:
- Make the
+ buttonactive when the user hovers over and clicks on it. - as well as theshow less
button too.
- Instead of a long list, let's use a dropdown here. The goal of the redesign is to show less information upfront and streamline user navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5551
Evidence
Screen.Recording.2026-07-01.at.10.55.45.PM.mov
Summary by CodeRabbit