fix: Split search / suggest results into an array? - #9
Open
webbrain-one wants to merge 1 commit into
Open
Conversation
Greptile SummaryThis PR changes search and suggestion responses from scalar strings to arrays by splitting Sonic’s space-delimited result payloads.
Confidence Score: 4/5The return-type change should not merge until its failing scalar-return assertions and public API examples are updated. Successful query and suggestion calls now return arrays, while the existing specs and documentation still enforce and advertise scalar results. Files Needing Attention: lib/sonic/channels/search.rb, spec/sonic/channels/search_spec.rb, README.md
|
| Filename | Overview |
|---|---|
| lib/sonic/channels/search.rb | Both search operations now return arrays, but the repository’s corresponding tests and public examples still require scalar responses. |
Reviews (1): Last reviewed commit: "Return search and suggest results as an ..." | Re-trigger Greptile
| execute('QUERY', *arr) do | ||
| connection.read # ... | ||
| end | ||
| execute('QUERY', *arr) { connection.read }.split(' ') |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6