Refactor instance tests around a network harness - #508
Open
samliok wants to merge 24 commits into
Open
Conversation
samliok
force-pushed
the
instance-test-refactor
branch
from
August 19, 2026 18:25
97c53ab to
d147e3d
Compare
samliok
marked this pull request as ready for review
August 20, 2026 21:53
samliok
force-pushed
the
instance-test-refactor
branch
from
August 21, 2026 15:15
4bb3bc9 to
5040547
Compare
samliok
commented
Aug 21, 2026
| // order to do so. | ||
| // We then check does so by checking they participated in signing | ||
| // Equivalent test as the previous TestInstanceMixedNodeType. | ||
| func TestNonValidator_BecomesValidator(t *testing.T) { |
Collaborator
Author
There was a problem hiding this comment.
equivalent to the previous: TestInstanceMixedNodeType
| // TestNonValidator_StaysNonValidator ensures that a non-validator does not restart when it is processing | ||
| // previous epoch changes. | ||
| // Equivalent to TestInstanceNonValidatorBootstraps | ||
| func TestNonValidator_StaysNonValidator(t *testing.T) { |
Collaborator
Author
There was a problem hiding this comment.
previously was TestInstanceNonValidatorBootstraps
| // then it is no longer a validator, and finally it is | ||
| // Equivalent to: TestInstanceValidatorSkipsAnEpoch. This also starts a validator when the tip is a sealing block so it covers an edge | ||
| // case previously caught from the logging test. | ||
| func TestInstanceValidatorSkipsAnEpoch(t *testing.T) { |
Collaborator
Author
There was a problem hiding this comment.
Equivalent to: TestInstanceValidatorSkipsAnEpoch. This also starts a validator when the tip is a sealing block so it covers an edge case previously caught from the logging test.
samliok
force-pushed
the
instance-test-refactor
branch
2 times, most recently
from
August 21, 2026 15:43
7ff7591 to
ed0e6d5
Compare
samliok
force-pushed
the
instance-test-refactor
branch
from
August 21, 2026 15:56
ed0e6d5 to
ac05817
Compare
samliok
force-pushed
the
instance-test-refactor
branch
from
August 21, 2026 16:01
ac05817 to
070a524
Compare
samliok
force-pushed
the
instance-test-refactor
branch
from
August 24, 2026 21:33
070a524 to
4ac8236
Compare
samliok
force-pushed
the
instance-test-refactor
branch
from
August 26, 2026 14:13
4ac8236 to
569e39c
Compare
samliok
force-pushed
the
instance-test-refactor
branch
from
August 26, 2026 14:20
569e39c to
274e913
Compare
samliok
force-pushed
the
instance-test-refactor
branch
from
August 26, 2026 21:17
dbea945 to
6287af1
Compare
samliok
force-pushed
the
instance-test-refactor
branch
from
August 27, 2026 20:09
6287af1 to
f933854
Compare
samliok
force-pushed
the
instance-test-refactor
branch
from
August 31, 2026 14:04
f933854 to
d4522b2
Compare
yacovm
reviewed
Sep 2, 2026
yacovm
reviewed
Sep 2, 2026
yacovm
reviewed
Sep 2, 2026
samliok
force-pushed
the
instance-test-refactor
branch
2 times, most recently
from
September 3, 2026 22:51
d9552c3 to
e86e081
Compare
The test covers ParsedBlock's Size and Bytes, which live in external.go, so it belongs beside them rather than in the instance tests. The body is unchanged.
Every one of them is rewritten against the network harness that follows, so they come out wholesale rather than being edited in place. The file is left holding only the helpers.
The per-test instance constructors, the storage polling helpers, testVM, the inMemNetwork message router and its networkSender all go away with the tests that used them. Trims the imports that went unused with them.
The file now holds only helpers. The new instance tests land in a fresh instance_test.go later in the series.
MockStorage parses stored blocks through an injected testInnerBlockDeserializer instead of the package level parseTestInnerBlock, and hands its WAL bookkeeping to a standalone walCreator. testPlatformChain wakes WaitForProgress waiters over a channel rather than a sync.Cond, looks up validator sets by exact height, and lets a test install a set at a height. reparseBlock inlines toRawBlock.
A network drives a set of nodes over an instanceComm that hands each message straight to the destination instance, and steps the chain one block at a time through a blockBuilderVM gated by a controlled block builder. Nodes start from a storage seeded with genesis, or from newChainStorage when a test needs the epoch defining block at the tip.
Each test builds a network and steps it a block at a time. Covers the epoch transition paths the old tests skipped: a non validator that becomes a validator, a validator dropped from the set, a node offline across a transition, and a validator that misses an epoch entirely.
adapters_test.go builds its node through the network harness instead of wiring an instance by hand, util_test.go follows the newTestPChain rename, and the instance logs the validator set it is notified of on an epoch change.
samliok
force-pushed
the
instance-test-refactor
branch
from
September 3, 2026 23:02
e86e081 to
48563fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final PR of the cleanup-instance stack (4/4), on top of the transition listener PR.
instance_testhelpers_test.go, rebuilt around anetworkharness:addNode,acceptNewBlock,waitUntilSealingBlock. The queue-basedinMemNetworkis replaced byinstanceComm, which delivers messages directly and re-parses blocks so recipients do not share mutable canoto state.instance_test.gobecomes short scenario tests. Epoch sealing tests now rely on production approval/aux info dissemination instead of hand-injecting approvals (removing the old TODO).TestParseBlockSizeMatchesBytesmoves verbatim toexternal_test.gonext toexternal.go.TestNonValidator_StaysNonValidator(replacingTestInstanceNonValidatorBootstraps) is skipped pending offline-node timeouts, andTestInstanceRestartAcrossEpochsis dropped (thenode.restart()helper remains unused).