Repository navigation
feat(shell): enable manual harness and runtime shell resumption - #2607
Open
nborges-aws wants to merge 1 commit into
Open
nborges-aws wants to merge 1 commit into
nborges-aws wants to merge 1 commit into
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Reviewed the diff for feat(shell): enable manual harness and runtime shell resumption. The implementation is clean and symmetric across the runtime and harness paths:
- A new
--shell-idflag is added to bothagentcore runtime shellandagentcore harness shell, validated with a sharedshellIdSchema, and gated behind--session-idwith a clearInputValidationError. shellIdis threaded end-to-end: handler flags → launch context → request normalizer → core opener → SDK input, and the server-assignedshellIdis surfaced back onRuntimeShellSession.ShellOperation.runnow prints a copy-paste reconnect command (and reminds the user to re-supply--bearer-token), which is a nice UX win. The bearer token is intentionally omitted from the reconnect string — good.- TUI deep-linking only forwards the
launchContextwhenlaunch.runtimeId === runtimeId, so a user switching runtimes via the picker won't accidentally send a staleshellId. - Tests cover the new flag plumbing, the
--shell-idwithout--session-idvalidation, bearer-token omission in the reconnect hint, and the end-to-end CLI → endpoint-picker → openShell path.
No telemetry gap worth flagging — telemetry in this repo lives at the router layer, not inside shell handlers.
Nothing I'd block the merge on.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2607 +/- ##
============================================
+ Coverage 96.58% 96.60% +0.01%
============================================
Files 700 700
Lines 57638 57681 +43
============================================
+ Hits 55672 55723 +51
+ Misses 1966 1958 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nborges-aws
added this pull request to stack #2610
October 16, 2026 15:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables resumption of shell sessions, via a
--shell-idflag. Both harness and runtime now accept--shell-idin parallel to--session-idto connect to a shell. Upon connection, the shell ID is printed alongside a reconnect command, with populated flags (and reminds users to reprovide bearer token where needed).Also updates command documentation and associated shell tests.
Verification
Type of Change
Testing
How have you tested the change?
Manual smoke testing with verification posted above. Also added tests focused around shell resumption behavior, all passing.
bun run test(4579 pass, 0 fail)npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.