Repository navigation
fix(deploy): surface recent CloudFormation failure reasons - #2615
Open
proton0210 wants to merge 1 commit into
Open
proton0210 wants to merge 1 commit into
proton0210 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2540 (deployment diagnostics described by the issue title).
A terminal toolkit error such as
NoStack: CloudFormationStack object does not hold a stackcan obscure the causal CloudFormation resource failure. Enrich final deployment failures with a best-effort, read-only DescribeStackEvents lookup, independently of verbose/progress output.The unrelated JSON-flag validation and online-eval deletion concerns mentioned in the issue body are not changed by this PR. Nested stacks are not recursively queried; wildcard-only selectors without concrete stack names are not expanded. Event lookup is best-effort and may not find a cause when events are not yet visible, inaccessible, outside the time/page window, or the stack has been deleted.
Type of Change
Testing
npm test: 6,365 passed across 443 files. Selected offline CLI integration tests (integ-tests/help.test.tsandinteg-tests/config.test.ts): 30 passed.All CloudFormation interactions were mocked. No AWS deployment or live failure was created, and no paid invocation was performed. The full integration suite was not run.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.