Repository navigation
fix(dev): use mounted AWS login cache in containers - #2616
Open
proton0210 wants to merge 1 commit into
Open
proton0210 wants to merge 1 commit into
proton0210 wants to merge 1 commit into
Conversation
13 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Container agents using
aws logincan fail withLoginTokenLoadErrorbecause botocore looks for its login cache under the container user's home even though the host AWS directory is mounted at/aws-config.In
ContainerDevRunner.run(), defaultAWS_LOGIN_CACHE_DIRECTORYto/aws-config/login/cachewhenever that AWS directory is mounted. A caller-supplied container cache path takes precedence. The value is written to the existing protected environment file, and the credential directory stays mounted read-only.This change targets
refactor, based onc480abb(1.0.0-rc.6), as requested in #2606. The fix and regression tests use that branch'ssrc/core/devimplementation and Bun test harness.Related Issue
Closes #2606.
Supersedes #2613 on the requested release branch.
Documentation PR
Not applicable: restores an existing credential source without adding a CLI option.
Type of Change
Testing
Regression first: the shared-config assertion and all three Docker/Podman/Finch login-cache tests failed before the production change. All 34 container-runner tests pass with the fix, including explicit container cache overrides, environment-file cleanup, and existing explicit-credential behavior.
Full
bun test: 4,578 tests passed across 307 files, 6 snapshots, zero failures.bun run typecheck,bun run lint:check,bun run format:check,bun run build, andbun run secrets:checkpass.git diff --checkpasses.bun run audit: no vulnerabilities found across 797 packages, using the branch's existing single-advisory exclusion.Built Node bundle smoke checks:
--versionreports1.0.0-rc.6;--helpsucceeds.Tested with Bun 1.4.0 and Node 24.19.0, using
bun install --frozen-lockfile; no dependency or lockfile changes.Relevant live AWS/container E2E tests were not run. The change is local credential-cache path configuration, covered through injected container-process boundaries with synthetic AWS config and temporary environment files. No real login tokens were read, refreshed, or modified.
I ran
bun testI ran the relevant end-to-end tests with
bun run test:e2e, or explained why they are not applicableI ran
bun run typecheckI ran
bun run lint:checkI ran
bun run format:checkI ran
bun run buildChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.