Conversation
bhavya76
force-pushed
the
bhavya76/eks-teardown-lock-fix
branch
from
September 17, 2026 10:12
8b7dda6 to
a6a22b4
Compare
bhavya76
force-pushed
the
bhavya76/eks-teardown-lock-fix
branch
from
September 17, 2026 14:18
a57f1b6 to
a6a22b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
When an EKS integration test's
terraform applyis killed mid-run (for example when the job's time cap SIGKILLs it while the validator is holding), it can leave an orphaned lock on the local terraform state. The teardownterraform destroythen fails to acquire the lock, so the cluster is never destroyed and leaks.Description of changes
Add
-lock=falseto the EKS teardownterraform destroy, so teardown can delete the cluster even when a prior apply left an orphaned local-state lock. Teardown is the final operation on that state, so skipping the lock here is safe.terraform applyis unchanged and still locks state normally.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
One-line change to the teardown step only; verified by inspection of the emitted
terraform destroycommand. The EKS integration job runs this destroy on teardown and exercises the change.Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.