Conversation
The client only checked that the selected cipher was a TLS 1.3 cipher at the negotiated version, so a server could pick any TLS 1.3 cipher even when the client offered a restricted subset. Also added UnsupportedCipherSuite-TLS13 runner test.
spwalgren
force-pushed
the
client-cipher-fix
branch
from
September 16, 2026 21:26
44d3e89 to
0b1e900
Compare
spwalgren
marked this pull request as ready for review
September 16, 2026 21:37
Contributor
|
🔒 Security Review — View Report Please review before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3537 +/- ##
==========================================
- Coverage 78.41% 78.20% -0.21%
==========================================
Files 700 700
Lines 125889 125886 -3
Branches 17413 17410 -3
==========================================
- Hits 98711 98451 -260
- Misses 26305 26563 +258
+ Partials 873 872 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client only checked that the selected cipher was a
TLS 1.3cipher at the negotiated version, so a server could pick anyTLS 1.3cipher even when the client offered a restricted subset.Also added
UnsupportedCipherSuite-TLS13runner test.Context and motivation
The client only checked that the selected cipher was a
TLS 1.3cipher at the negotiated version, so a server could pick anyTLS 1.3cipher even when the client offered a restricted subset.Description of changes
The client's cipher-suite validation now additionally requires that the selected cipher appear in the client's configured cipher list rather than checking protocol version alone.
Something to note: The default client configuration offers all supported
TLS 1.3ciphers so those handshakes are unaffected. Clients that configure their own ciphers can have handshakes fail.Testing
Added
UnsupportedCipherSuite-TLS13to the runner suite and existing tls tests still pass.Review considerations
Compatibility: Handshakes that previously succeeded will now fail when a server selects a
TLS 1.3cipher outside the client's configured list. This is the specified behavior and affects only non-conforming peers, but it is a behavior change for clients that both restrict their suites and talk to such a peer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.