[BUGFIX] Implement PreviewRendererInterface in GridRenderer#756
Open
torben-fr wants to merge 1 commit into
Open
[BUGFIX] Implement PreviewRendererInterface in GridRenderer#756torben-fr wants to merge 1 commit into
torben-fr wants to merge 1 commit into
Conversation
As the `GridRenderer` needs to implement the `PreviewRendererInterface` for it to be resolved successfully by the `StandardPreviewRendererResolver` as seen in [1], the `GridRenderer` was adjusted to extend the `StandardContentPreviewRenderer` to solve this issue. Directly implementing the interface here would mean to also add the 4 missing functions the interface demands to the `GridRenderer` which would most probably only be a useless code duplication. [1] https://github.com/TYPO3-CMS/backend/blob/f842410118ea059292dc697e3c085e5b12ea41f0/Classes/Preview/StandardPreviewRendererResolver.php#L85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the
GridRendererneeds to implement thePreviewRendererInterfacefor it to be resolved successfully by theStandardPreviewRendererResolveras seen in [1], theGridRendererwas adjusted to extend theStandardContentPreviewRendererto solve this issue. Directlyimplementing the interface here would mean to also add the 4
missing functions the interface demands to the
GridRendererwhich would most probably only be a useless code duplication.
[1] https://github.com/TYPO3-CMS/backend/blob/f842410118ea059292dc697e3c085e5b12ea41f0/Classes/Preview/StandardPreviewRendererResolver.php#L85