Skip to content

fix: filter() without an amount produces a double slash #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Baspa merged 5 commits into from
Jun 18, 2026
Merged

fix: filter() without an amount produces a double slash #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8369e0
fix: omit empty amount segment in filter() when no amount given
Baspa Jun 18, 2026
e4a89cb
Merge branch 'main' into fix/filter-optional-amount
Baspa Jun 18, 2026
350ddbc
Merge branch 'main' into fix/filter-optional-amount
Baspa Jun 18, 2026
1ec9cff
Merge branch 'main' into fix/filter-optional-amount
Baspa Jun 18, 2026
1061e6b
test: trigger workflow
Baspa Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Transformations/Filter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ public static function validate(string $key, ...$args): bool
public static function generateUrl(string $url, array $values): string
{
// -/filter/:name/:amount/
$url .= '-/filter/' . $values['name'] . '/' . $values['amount'] . '/';
if ($values['amount'] === null) {
$url .= '-/filter/' . $values['name'] . '/';
} else {
$url .= '-/filter/' . $values['name'] . '/' . $values['amount'] . '/';
}

return $url;
}
Expand Down
11 changes: 11 additions & 0 deletions tests/TransformationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,17 @@
expect($url)->toBe('https://ucarecdn.com/12a3456b-c789-1234-1de2-3cfa83096e25/-/strip_meta/sensitive/');
});

it('omits the amount segment in filter when no amount is given', function () {
$uuid = '12a3456b-c789-1234-1de2-3cfa83096e25';

$url = (string) uploadcare($uuid)->filter('adaris');
expect($url)->toContain('-/filter/adaris/');
expect($url)->not->toContain('adaris//');

$url = (string) uploadcare($uuid)->filter('adaris', 50);
expect($url)->toContain('-/filter/adaris/50/');
});

it('honors the boolean argument in autoRotate', function () {
$uuid = '12a3456b-c789-1234-1de2-3cfa83096e25';

Expand Down