Build with Go 1.27.1, update dependencies, add make check - #150
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The dependency versions are valid and the build and validation updates are internally consistent.
Pull request overview
Updates Thruster’s Go toolchain, dependencies, and local validation tooling.
Changes:
- Requires Go 1.27.1 and updates dependencies.
- Pins
govulncheckas a module tool. - Adds
make checkfor vetting and vulnerability scanning.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
Makefile |
Adds the check target. |
go.mod |
Updates Go, dependencies, and tool configuration. |
go.sum |
Refreshes checksums for the updated module graph. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
klauspost/compressv1.19.2 -> v1.20.0,stretchr/testifyv1.8.4 -> v1.12.1.x/cryptoandx/netare already current. The testify update replaces six old indirect modules withgo.yaml.in/yaml/v3, which also covers the open dependabot PR for testify.make checktarget that runsgo vetandgovulncheck. govulncheck is added as a module tool via thetooldirective ingo.mod, so its version is pinned and it runs withgo tool govulncheck.Verification
go build ./...,go vet ./...,make test(also with-race) pass.golangci-lint runreports 0 issues.make distbuilds all four linux/darwin targets.make checkpasses. govulncheck finds 0 vulnerabilities in the code. It reports one advisory in a required module (GO-2026-5932, the unmaintainedx/crypto/openpgppackage), which Thruster does not import and which has no fixed version.X-Request-Idheader.