Repository navigation
ci(dependabot): required the real CI before auto-merging - #2
Merged
Merged
Conversation
automation-templates#115 merges a Dependabot PR only after green CI. Until now any passed check counted as green, so a PR whose build never ran could be merged on GitGuardian or a notification job alone. #115 adds the input required-workflows: every listed workflow must have a pull_request run on the PR head commit whose latest attempt succeeded, and without the input nothing is merged. This names docker-release.yml: on every PR that changes a file this caller starts for, it builds the image. Merge only after automation-templates#115: until then the called workflow on main does not declare the input and GitHub rejects the call. Refs bauer-group/automation-templates#115
Contributor
|
🎉 This PR is included in version 0.6.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
required-workflows: .github/workflows/docker-release.ymlin the call ofdocker-maintenance-dependabot.ymlin.github/workflows/docker-maintenance.yml, with a comment saying what that workflow tests.Why
bauer-group/automation-templates#115 merges a Dependabot PR only after green CI. Until its latest revision, "green" meant at least one passed check of any kind, so a PR whose real build never ran (its paths did not match) would have been merged when only GitGuardian, a Teams notification or an AI-summary job had passed - the shape of bauer-group/CI-GitHubRunner#13 and bauer-group/CS-GitHubBackup#1. #115 therefore adds the input
required-workflows: a PR is merged only when every listed workflow has apull_requestrun on the PR head commit whose latest attempt succeeded - on top of the other rules (no failed or pending check, settle and quiet time, only verified Dependabot commits,gh pr merge --match-head-commit). Without the input nothing is merged. GitHub Actions updates and any PR that changes.github/are never merged automatically.Which CI tests the Dependabot updates here
docker-release.yml validates the compose files and shell scripts and builds src/Dockerfile on every PR that changes it.
Jobs of
.github/workflows/docker-release.ymlthat run on a pull request:🔍 Validate Docker Compose,🔍 Validate Shell Scripts,🔨 Validate Docker Build (PR).Dependabot entries in
.github/dependabot.ymlonmain(8fbef33), with the files each one can change and thepull_requestworkflows whose path filters match them:docker/srcsrc/Dockerfiledocker-release.ymlgithub-actions/Stays open for manual review
.github/(#115 never merges them).merge-update-typesdefaults topatch).Evidence
.github/workflows/docker-release.ymlpull_request run 32960154898 -> success (https://github.com/bauer-group/CS-ClientPublicIP/actions/runs/32960154898)pathverbatim; on this fleet'spull_requestruns that field is exactly the file, e.g..github/workflows/docker-release.yml(read through the Actions API today)..github/workflows/docker-release.yml) accepts the value:Required workflows: .github/workflows/docker-release.yml.dependabot.ymlwere read from the default branch through the GitHub API on 2026-10-09; the branch merges cleanly into the current default branch (git merge-tree).actionlintreports no findings for the changed file.