Skip to content

Pin crate dependency resolution - #283

Open
Silic0nS0ldier wants to merge 1 commit into
bazel-contrib:masterfrom
Silic0nS0ldier:pin-crates
Open

Pin crate dependency resolution#283
Silic0nS0ldier wants to merge 1 commit into
bazel-contrib:masterfrom
Silic0nS0ldier:pin-crates

Conversation

@Silic0nS0ldier

Copy link
Copy Markdown

As of @rules_rust 0.71.1 non-root modules must pin their dependencies.

This change landed in bazelbuild/rules_rust#4109.
https://github.com/bazelbuild/rules_rust/pull/4109/changes#diff-7a86616f74944ee7c3932ee97054ae586b1f28573393c592e3a3e9a7550e3eceR619-R634

Beyond being required, locking these dependencies also makes supply chain attacks more difficult. Elimination of the on-demand dependency resolution should also speed up builds a little.

@Silic0nS0ldier

Copy link
Copy Markdown
Author

CI errors look to be an unrelated issue (CcInfo no longer being global).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant