[9.3.0] Don't synchronize RemoteExternalOverlayFileSystem#getInputStream (h… - #30905
Merged
Merged
Conversation
…azelbuild#30791) Synchronization is unnecessary as individual methods called by this implementation are already synchronized. It is also harmful since `getInputStream` awaits a network transfer. Progress towards bazelbuild#30780 No - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). RELNOTES: None Closes bazelbuild#30791. PiperOrigin-RevId: 968392939 Change-Id: Ic48cfa823322e67c6cd0344a91333284b496f3b0
iancha1992
added
team-Remote-Exec
iancha1992
enabled auto-merge
August 27, 2026 21:49
tjgq
approved these changes
Sep 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 1, 2026
|
We might need as retry on that merge queue, looks like a couple of jobs hung |
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ttps://github.com//pull/30791)
Synchronization is unnecessary as individual methods called by this implementation are already synchronized. It is also harmful since
getInputStreamawaits a network transfer.Progress towards #30780
No
RELNOTES: None
Closes #30791.
PiperOrigin-RevId: 968392939
Change-Id: Ic48cfa823322e67c6cd0344a91333284b496f3b0
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit 16d479f