[9.3.0] Add resource_set to map_directory (https://github.com/bazelbuild/baze… - #30906
Closed
iancha1992 wants to merge 2 commits into
Closed
iancha1992 wants to merge 2 commits into
iancha1992 wants to merge 2 commits into
Conversation
This allows setting the resource requests for every nested action created by the map_directory lambda Closes bazelbuild#30577. PiperOrigin-RevId: 961950045 Change-Id: I2c780e50c695a2cc314c5841ba13a21d1ae502bc
iancha1992
added
team-Configurability
Previously this only allowed a top level starlark function. Now users still can't pass lambdas but they can pass pre-computed dictionaries with the relevant elements. This is useful since at the action creation time the rule author can very likely know these ballpark resource requests, but they don't have all the context from a top level function. Fixes bazelbuild#15187 Closes bazelbuild#29285. PiperOrigin-RevId: 947146946 Change-Id: I667042b7266efbfe29ca503a64a8a87a37c39bbb
Member
|
@keith the test failures look related |
iancha1992
commented
Aug 28, 2026
| "output_dir": output_dir, | ||
| }, | ||
| tools = { | ||
| "cat_tool": ctx.attr.cat_tool.files_to_run, |
Member
Author
Member
auto-merge was automatically disabled
August 28, 2026 21:40
Pull request was closed
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l/pull/30577)
This allows setting the resource requests for every nested action created by the map_directory lambda
Closes #30577.
PiperOrigin-RevId: 961950045
Change-Id: I2c780e50c695a2cc314c5841ba13a21d1ae502bc
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit d5348b3 and 6ac8c84