Skip to content

fix: await account changes and repair core layer types - #1826

Draft
Jacky-Pham wants to merge 2 commits into
Jacky/strr-shared-contracts-20260915from
Jacky/strr-core-layer-contracts-20260915
Draft

Jacky-Pham wants to merge 2 commits into
Jacky/strr-shared-contracts-20260915from
Jacky/strr-core-layer-contracts-20260915

Conversation

@Jacky-Pham

@Jacky-Pham Jacky-Pham commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

The core account dropdown treated an asynchronous route callback as an approved switch before navigation completed. Await its result and ignore an older decision after a newer menu selection. The current account is preserved while navigation is pending, cancelled or rejected. Nine regressions use the real navigation composable, route metadata and account store.

Repair the core layer's Nuxt 4 declarations and internal imports, register its existing app-config/page-meta types, and resolve circular theme inference. Config inputs remain optional across layers; the resolved runtime configuration remains required. Shared button variant contracts and modal callers now match the inferred Nuxt UI types. Each frontend installs the same exact-version dependency patch; dependency versions and runtime configuration values are unchanged.

Validation on Node 24/pnpm 10.21:

  • The initial behavioral baseline fails 3 of 7 cases; all 9 final cases pass, including rejection and stale-decision coverage added afterward. Tests explicitly import the patched package under the normal remote-base configuration.
  • All five standard frontend lint/test/build workflows pass on f447a483, with 727 tests. All 37 PR checks are successful or intentionally skipped.
  • Combined CI 35035169663 passes all five lint/test/build jobs and 1,053 frontend tests on 45f59fe9.
  • Paired strict checks reduce standalone diagnostics 581→425 and combined diagnostics 289→145, with none introduced. Strict checks remain failing elsewhere.
  • All five patch copies are identical, installed changed files match the patch source, lockfile versions are unchanged, and original/repaired runtime config objects are deeply equal.

Stacked on #1825. This is not a full component sign-off; remaining type errors, backend lint and browser coverage are tracked separately.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant