fix: await account changes and repair core layer types - #1826
Draft
Jacky-Pham wants to merge 2 commits into
Draft
Jacky-Pham wants to merge 2 commits into
Jacky-Pham wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The core account dropdown treated an asynchronous route callback as an approved switch before navigation completed. Await its result and ignore an older decision after a newer menu selection. The current account is preserved while navigation is pending, cancelled or rejected. Nine regressions use the real navigation composable, route metadata and account store.
Repair the core layer's Nuxt 4 declarations and internal imports, register its existing app-config/page-meta types, and resolve circular theme inference. Config inputs remain optional across layers; the resolved runtime configuration remains required. Shared button variant contracts and modal callers now match the inferred Nuxt UI types. Each frontend installs the same exact-version dependency patch; dependency versions and runtime configuration values are unchanged.
Validation on Node 24/pnpm 10.21:
f447a483, with 727 tests. All 37 PR checks are successful or intentionally skipped.45f59fe9.Stacked on #1825. This is not a full component sign-off; remaining type errors, backend lint and browser coverage are tracked separately.