fix: normalize session settings and release modal timers - #1831
Closed
Jacky-Pham wants to merge 1 commit into
Closed
Jacky-Pham wants to merge 1 commit into
Jacky-Pham wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The shared session-expiry modal starts a countdown interval each time it mounts but never clears it on unmount. Repeated modal instances leave old countdown timers running. The core layer also takes explicit session timeout values directly from process.env, making its four session settings strings instead of numbers when the documented environment values are supplied.
Keep the countdown interval handle and clear it in the existing unmount hook. Convert the four timeout settings to numbers at the configuration source, preserving millisecond units, existing defaults, empty-value fallback and explicit zero. Existing consumers already coerce numeric strings through division or timers; this change does not establish or claim a prior login failure.
Validation:
Paired strict checking on all five packages introduces no new diagnostics: the supplied-example profile improves from 343 to 323 overlapping diagnostics (five session-setting errors removed per consuming app), while default-profile diagnostics remain 342. Other pending repairs are exercised separately on the combined QA branch. Strict gates are still failing.
All five standard frontend workflows pass lint, 768 tests and builds on this head. Combined-source CI 35039423348 passes all five lint/test/build jobs and 1,094 frontend tests on QA 93bf653. Combined strict checking removes the same 20 session diagnostics with no additions: supplied-example profile 70→50; defaults remain 65. Base passes strict checking under both profiles; the four applications still fail. All 37 PR checks are terminal: 22 success and 15 unused npm jobs skipped.
Stacked on #1830; full component and browser sign-off remains open.