fix: declare frontend date dependencies and expiry contract - #1834
Draft
Jacky-Pham wants to merge 1 commit into
Draft
Jacky-Pham wants to merge 1 commit into
Jacky-Pham wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Host and Examiner import Luxon directly without declaring it, causing four missing-module/type errors. Add Luxon 3.7.2 and @types/luxon 3.7.1 to both apps, matching Base's existing locked versions. No existing dependency resolution changes.
The now-available Luxon types expose the shared registration expiry-date mismatch: the API serializes an ISO string, while the frontend declared a Date. Correct that field to string so Host renewal calculations use the actual response contract.
Add seven passing controls covering rendered Pacific filing-history dates and document-upload timestamp comparisons. These checks passed before the dependency change; this PR does not claim a reproduced production date-rendering failure.
Validation:
71d8a5ab925fb0b439b44381b1f07aeda99ec777: all five apps passed lint, 1,122 tests, and builds.6ebcd0854efba418e620f09bb6423db6d8a5969fpassed: Base, Host, and Examiner.Stacked on #1833. Draft for review; no deployment.