fix: refresh Host dashboard immediately after account changes - #1837
Draft
Jacky-Pham wants to merge 1 commit into
Draft
Jacky-Pham wants to merge 1 commit into
Jacky-Pham wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing accounts on the new Host dashboard can leave the previous account's rows visible and postpone the newest account's list requests until an earlier request finishes. Both tables currently use Nuxt's option-watch refresh queue, which serializes a trailing refresh behind the active one.
Keep the table instances mounted and explicitly refresh when account, page or search state changes. Clear data when the account ID changes, and register the watcher before awaiting initial data. This starts the current account's request without waiting for the older request and prevents old rows/results from being displayed under the new account. Existing request debouncing and same-account pagination/search behavior are retained.
Nine integration cases use the actual page, tables, core account store, Nuxt asynchronous-data handling and persistence helpers with synthetic API responses. The original component source has three failures and six passing controls. Cases include initial-load account changes, overlapping requests, immediate clearing of old rows, normal refresh, search/page reset, and recovery after either table request fails. HTTP headers and authenticated browser navigation are separate checks.
Validation on review head
2806a0974793b078c95feb449e222d523f8cd916:c27ad97a79643d51cc0cc80d8e9bcc650e8ef94f: all five lint/test/build jobs pass, with 1,158 tests (Base 41, Host 491, Platform 57, Strata 80, Examiner 489).Stacked on #1836. The separate legacy Host and Strata list dashboards and live authenticated navigation remain additional verification work.