fix: ignore upload completions after changing records - #1839
Draft
Jacky-Pham wants to merge 1 commit into
Draft
Jacky-Pham wants to merge 1 commit into
Jacky-Pham wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Host application/registration or Strata application upload can finish after the user loads a different record. Its response then compares against the new record's documents and inserts an old file into the new list. A late failure also opens an error dialog over the new record.
Capture the document list when the request starts and apply its response or error dialog only while that list remains active. Record loaders and reset actions replace the list. Loading flags still clear, and active-record failures still reject for the existing retry flow. The server request continues against its original record.
Fifteen regression tests use the actual document stores, record loaders, rendered document lists, and API plugin with local synthetic endpoints. Before the fix, nine stale-completion/reset cases fail and six normal-upload controls pass. All fifteen pass after the fix. Full local suites pass 461 Host and 76 Strata tests, with clean lint.
Stacked on
Jacky/strr-upload-context-base-20260915, which combines #1838 with the upload response/queue prerequisites from #1803 and #1822. This PR changes only the two document stores and their new regression tests. Browser navigation and real uploads remain separate checks.Validation on review head
f2652df0ce990f61fae3befe6cc6683633ba405f:9c7bf684b7c155ecb00dab4d0142b2c27983e96c: all five lint/test/build jobs pass; 1,183 tests (Base 41, Host 506, Platform 57, Strata 90, Examiner 489).This repair covers additional uploads to existing applications and Host registrations. The separate first-time
postDocumentpath remains under investigation.