fix: preserve renewal task and application ID type correlation - #1843
Draft
Jacky-Pham wants to merge 3 commits into
Draft
Jacky-Pham wants to merge 3 commits into
Jacky-Pham wants to merge 3 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform and Strata dashboards could not type-check renewal delete/payment callbacks because the shared helper returned independent presence flags and nullable application IDs. The API supplies a non-null application number for draft and payment-pending tasks. Model that distinction and preserve the link between each presence flag and its ID.
Seventeen behavior controls cover actual helper/API-client results and each dashboard's resume, delete/refresh, and token/no-token payment actions. All pass before and after. Tests use the helper selected by Nuxt and controlled API/navigation boundaries; they do not perform authenticated navigation or live writes. The existing test-only Sonar duplication exclusion is extended to Platform and Strata tests; production code scanning and thresholds are unchanged.
Validation: full local Base (39), Platform (52), and Strata (97) suites and lint pass; combined local Platform (62) and Strata (111) also pass. Fresh all-five strict checks remove exactly four errors, with none added: combined 40 → 36 default and 25 → 21 configured (profiles overlap). Final Base, Platform, and Strata CI all pass lint/tests/builds on
3a744226; combined CI passes all five frontend jobs with 1,240 tests onb539c941. SonarCloud passes.Based on an isolated integration of #1842 and #1804. No main merge or deployment.