Skip to content

34969 - help me choose modal tweak #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kialj876 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

34969 - help me choose modal tweak #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.10.1",
"version": "5.10.2",
"private": true,
"engines": {
"node": ">=24"
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/dialogs/numbered-company-help.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
<ul>
<li>combine or merge your business with another business (Amalgamation)</li>
<li>reactivate a business (Restoration)</li>
<li>move your business out of B.C. (Continuation-out)</li>
</ul>
<p class="font-weight-bold">
Note: all businesses in Corporate Online will be moved to the new BC Business Registry soon
Expand Down Expand Up @@ -108,6 +107,7 @@
<li>change your business address when you move</li>
<li>change directors names or addresses</li>
<li>change basic business information (Alteration)</li>
<li>move your business out of B.C. (Continuation-out)</li>
</ul>
<v-btn
id="help-business-registry-btn"
Expand Down
2 changes: 1 addition & 1 deletion app/tests/unit/dialogs/numbered-company-help.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ describe('NumberedCompanyHelpDialog', () => {
expect(coCard.text()).toContain('For complex filings.')
expect(coCard.text()).toContain('combine or merge your business with another business (Amalgamation)')
expect(coCard.text()).toContain('reactivate a business (Restoration)')
expect(coCard.text()).toContain('move your business out of B.C. (Continuation-out)')
expect(coCard.text()).toContain('Note: all businesses in Corporate Online will be moved')
const coBtn = coCard.find('#help-corporate-online-btn')
expect(coBtn.text()).toContain('Continue to Corporate Online')
Expand All @@ -83,6 +82,7 @@ describe('NumberedCompanyHelpDialog', () => {
expect(brCard.text()).toContain('change your business address when you move')
expect(brCard.text()).toContain('change directors names or addresses')
expect(brCard.text()).toContain('change basic business information (Alteration)')
expect(brCard.text()).toContain('move your business out of B.C. (Continuation-out)')
const brBtn = brCard.find('#help-business-registry-btn')
expect(brBtn.text()).toContain('Use the New BC Business Registry')
expect(brBtn.attributes('disabled')).toBeUndefined()
Expand Down
Loading