FEAT: Add devcontainer setup + fix automated environment building - #53
Draft
felixdivo wants to merge 5 commits into
Draft
FEAT: Add devcontainer setup + fix automated environment building#53felixdivo wants to merge 5 commits into
felixdivo wants to merge 5 commits into
Conversation
EVENT_METRICS (map_iou) was defined but never merged into ALL_METRICS, causing every event-detection test (mitdb dataset) to fail with KeyError: 'map_iou'. Also add map_iou/vus_roc/vus_pr to HIGHER_IS_BETTER, which had the same kind of omission. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
felixdivo
force-pushed
the
add-devcontainer
branch
from
July 9, 2026 15:08
7d70e27 to
79ec076
Compare
CI's benchopt_dev job runs `benchopt test --env-name bench_test_env`, a single shared conda env across all solvers/datasets. objective.py's bare `scikit-learn` requirement (no `pip::` prefix) installed scipy/numpy via conda, which carries no pip RECORD metadata. When Toto-2.0's pip-installed dependencies later needed to upgrade scipy, pip couldn't touch the conda-installed copy and crashed with `uninstall-no-record-file`. Prefixing these bare requirements with `pip::` keeps every Python-level dependency in the shared env resolved through pip consistently. Verified by reproducing the shared-env code path locally with `--env-name` (which plain `benchopt test .` never exercises, since it uses per-test temp envs) across both CI phases (fresh install and --skip-install). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devcontainers are a tool nicely integrated into VS Code that lets you set up a Docker container with minimal effort (though you have to wait for the environment to be set up).