parse rgba/hsla/hsva with optional alpha (#274) - #286
Open
cpruijsen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS Color 4 (the grammar quoted in #274) makes the alpha group on
rgba()optional:TinyColor required a fourth CSS unit, so
rgba(255, 0, 0)did not parse (isValid() === false, color acted like black). Same matcher is used forhsla()/hsva().Fixes #274
Summary
PERMISSIVE_MATCH4(shared byrgba/hsla/hsva) now takes three components with an optional fourth./is accepted as the separator before that optional alpha, matching the modern form in the issue (rgba(255 0 0 / 0.5)).boundAlphapath. Four-value comma forms are unchanged.Decision
*amatcher, including slash-separated alpha./would parsergba(255 0 0 / 0.5)as opaque red, because the matchers are unanchored and leftover input is ignored. Happy to drop slash, or to limit this torgba, if you prefer.Generated UMD/CJS/ESM copies are produced by
deno task buildand are not in this commit. I can add a build commit if you want the CDN copies updated here.Test plan
rgba(255, 0, 0)andrgba 200 100 0parse (isValid(), equals the RGB object, alpha 1 viatoRgbString)rgba(90%, 45%, 0%)without alpha still parsesrgba(255 0 0 / 0.5)keeps alpha 0.5rgba(255, 0, 0, 0.5)/rgba 200 100 0 .4(existing four-value) still workhsla(...)/hsva(...)without alpha parsedeno test test.js, 45 passed, 1 ignored