fix(feeds): apply optimistic account votes to feed vote counts - #114
Merged
Conversation
`useFeed` now applies the active account's pending votes to `upvoteCount` and `downvoteCount` with the same `addOptimisticVoteCountsToComments` helper used by `useComments` and `useReplies`, so voting from a feed updates the score immediately.
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useFeednow selects the active account'saccountsVotesentry and applies it tofeed,bufferedFeed, andupdatedFeedviaaddOptimisticVoteCountsToComments, the same helper and selector pattern already used byuseCommentsanduseReplies.upvoteCount/downvoteCountimmediately instead of waiting for the community to publish new counts, so feed scores match comment pages.feeds.test.tsregression test that sets a pending account vote and asserts the feed count changes; README and generated llms files updated.Verification
oxfmt --checkon the changed source filessrc/hooks/feeds/feeds.test.ts(61 tests pass)yarn buildCloses #113
Note
Low Risk
Localized UI-layer normalization in
useFeedreusing an existing helper; no auth, publishing, or protocol changes.Overview
useFeednow mirrors comment/reply hooks for vote scores. It reads the active account’s pending votes from the accounts store and runsaddOptimisticVoteCountsToCommentsonfeed,bufferedFeed, andupdatedFeed(after moderation normalization), so upvoting from a feed bumps counts immediately instead of waiting for canonical community data.A regression test in
feeds.test.tsasserts that a pending account vote increasesupvoteCounton a feed item. Docs (README.md,llms-full.txt) now listuseFeedalongside the other hooks that apply optimistic vote adjustments.Reviewed by Cursor Bugbot for commit 0c678d0. Bugbot is set up for automated code reviews on this repo. Configure here.