[CTX-0059] fix(campaign): require admission and run-owned cleanup - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Task: CTX-0059. Closes #105.
Run preflight before dispatch, default to read-only probes, require disposable-instance consent and target attestation for mutations, and clean up only run-owned workspace IDs. Paths use host-correct absolute semantics. Unknown thrown values become report failures. Independent keystroke opt-in remains separate; path attestation does not authenticate a peer. No new protocol version or core scope change.
Review and verification
Independent round-three APPROVE PX-0264. Delivery commander read the entire diff and verified approved blobs src/campaign.ts 28f2d4a0bb9c9790b0146708b1f4d5499e21d542 and tests/campaign.test.ts 19f8fe4999dad8473893f4058c384b74f7150538 unchanged. Scoped Bun 72 passed/225 assertions; full Bun 320 passed/1347 assertions. Typecheck/build, pinned Prettier, markdownlint, scoped oxlint, diff check and prepush gitleaks passed. Offline locked cargo fmt/check/clippy/test also passed (56 tests), no Rust edits. Recording fakes and existing local synthetic fixtures only; no live campaign or Windows integration claim. Pinned Prettier authoritative; recorded oxfmt default differences are not a passing oxfmt gate.
Documentation and ordering
Canonical docs requirements prepared and separately tracked in bitty-terminal-docs CarryCtx CTX-0026 (specifications/devtools-rfc.md; PX-0265 requirements). Linked docs pending, not implemented or verified. User authorizes code merge/closing linkage while docs are tracked; source task stays REVIEW and no completion is claimed. CTX-0055 PR #115 merged first; CTX-0053 follows this PR. No snapshots/export/publication or worktree cleanup.