[CTX-0071] feat(devtools): implement wire-trace flag per accepted design (#120) - #127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the accepted wire-trace design (child of #72) for
bitty-devtools:trace start|stop|fetch-chunkgated by argv-presence-only--wire-trace(default off).Task / RFC / Issue
Scope
Exactly 4 files (approved blobs unchanged):
Behavior
traceverbs without--wire-traceexit 2;inspect --wire-traceexits 2;--wire-trace=<value>rejected.debug.traceper call (debug.inspectalone yields ScopeDenied exit 7); neverdebug.control.--duration-ms/--max-bytes/--include-input/--trace-id/--offsetplus reused--socket/--instance/--json.includeInputdefaults false with typed redaction, 8 KiB/record cap, 512-char preview, preview==export assert.Evidence (qualified)
bun test: 389 pass / 0 fail, 3123 expects; scoped cli 42 pass, tracing 30 pass.tsc --noEmitclean;buildclean (dist/cli.js,dist/tracing.js).inspection.tsunused-PanelId warning); markdownlint-cli2 0 issues;git diff --checkclean.token=sk-live-...in tests/tracing.test.ts:651, asserted redacted (part of approved blob); no repo gitleaks gate; assessed benign.Docs sync
RFC amendment text comes from CTX-0066 and follows separately — code merge OK; issue closes via merge only if docs tracked (per task description, merge with docs tracked separately, keeping
Closes).Commit hook
Lefthook pre-commit + commitlint commit-msg hooks pass (no bypass, no bunx, no installs).