creating qa skill based on retro feedback

[prograhamming]

🎟️ Tracking

AI-27

📔 Objective

[github-actions]

Plugin Validation Summary — PR #162

Scope: New skill evaluating-qa-readiness added to bitwarden-atlassian-tools.

Files reviewed:

• plugins/bitwarden-atlassian-tools/skills/evaluating-qa-readiness/SKILL.md (new)
• plugins/bitwarden-atlassian-tools/skills/evaluating-qa-readiness/examples/sample_evaluation.md (new)
• plugins/bitwarden-atlassian-tools/skills/evaluating-qa-readiness/references/criteria.md (new)

Overall: ❌ Request changes — one blocking policy violation. The skill itself is structurally sound, secure, and high quality; the PR is missing the mandatory version bump and changelog entry.

---

🔴 Critical (must fix)

1. Missing mandatory version bump + changelog entry for a substantive change
.claude/CLAUDE.md requires that any substantive plugin change — explicitly including adding a new skill — bumps the semantic version across all files and adds a CHANGELOG.md entry, in the same PR. This PR adds a whole new skill but leaves the version untouched:

• plugins/bitwarden-atlassian-tools/.claude-plugin/plugin.json:3 — still "version": "2.2.8"
• .claude-plugin/marketplace.json:51 (the bitwarden-atlassian-tools entry) — still "version": "2.2.8"
• plugins/bitwarden-atlassian-tools/CHANGELOG.md:8 — latest entry is ## [2.2.8] - 2026-07-01 (about pnpm); no entry for this skill

Adding a backward-compatible feature is a MINOR bump: 2.2.8 → 2.3.0.

Remediation:

echo "y" | ./scripts/bump-plugin-version.sh bitwarden-atlassian-tools 2.3.0

(updates plugin.json + marketplace.json; no AGENT.md files exist). Then add to CHANGELOG.md under a new ## [2.3.0] - <date> / ### Added heading, e.g.:

Added evaluating-qa-readiness skill that checks a Jira ticket for the information QA needs before testing (testing instructions, implementation notes, feature-flag state, acceptance criteria, affected clients, linked PR/build) and drafts a developer ask for any gaps.

After bumping, re-run ./scripts/validate-plugin-structure.sh bitwarden-atlassian-tools and ./scripts/validate-marketplace.sh bitwarden-atlassian-tools to confirm name/version consistency.

---

🟠 Major (should fix)

2. Skill description is over-length — SKILL.md:3
The description field is ~817 characters, roughly 60% over the ~500-char guideline. The trigger phrases and proactive-use clause are excellent and should stay; the tail that re-enumerates every criterion (feature flag state, testing instructions, implementation notes, acceptance criteria...) duplicates the SKILL.md body and belongs there, not in the description. A description's job is triggering, not summarizing the workflow.

Remediation: Trim to trigger phrases + one-line purpose + proactive clause (~500 chars); drop the criterion enumeration, which is already in the body.

---

🟡 Minor (optional)

3. Occasional second-person phrasing in Step 2 — SKILL.md:24-28
Phrases like "you gathered" / "you need both" break from the otherwise consistent imperative voice. Acceptable and idiomatic; tighten only if convenient.

4. Criteria summary duplicates the reference — SKILL.md:32-42 vs references/criteria.md
The inline blocking/non-blocking summary intentionally aids the workflow and is short enough to justify keeping. No change needed, but keep the two copies in sync on future edits.

---

✅ Passing checks

Plugin structure (plugin-validator)

• plugin.json valid JSON; name kebab-case, version valid semver, description/author/keywords well-formed; no unknown fields.
• New skill sits correctly under auto-discovered skills/; SKILL.md at skill root; examples/ and references/ present.
• Frontmatter name: evaluating-qa-readiness matches the directory exactly; both required fields present.
• Both referenced files resolve and exist: references/criteria.md (SKILL.md:30), examples/sample_evaluation.md (SKILL.md:93-95).
• .mcp.json untouched and sane — stdio type, secrets injected via ${VAR} env interpolation, ${CLAUDE_PLUGIN_ROOT} used for portability.

Skill quality (skill-reviewer)

• Word counts in ideal range: SKILL.md body ~1,140 words (target 1,000–3,000); criteria.md 762; sample_evaluation.md 519.
• Textbook progressive disclosure: lean core workflow, detailed criterion definitions in references/, complete worked example in examples/, both pointed to from the core.
• Trigger phrases are concrete, quoted, and varied → reliable auto-invocation. Third-person/imperative form is correct.
• Strong "Boundaries and honesty" section (read-only MCP, no fabrication, don't trust ticket status as evidence).

Security (reviewing-claude-config)

• No committed secrets, API keys, tokens, or passwords in any of the three files.
• No settings.local.json, settings files, or permission/auto-approval changes in this PR.
• Only credential-adjacent matches are descriptive product-feature references ("master-password reprompt", "reset-password step") — documentation, not secrets.

---

Bottom line

The new skill is well-designed, secure, and ready on its own merits. Blocking issue: add the 2.3.0 version bump (plugin.json + marketplace.json) and a matching CHANGELOG.md entry in this PR. Recommended: trim the over-length description. Everything else is optional polish.

[SaintPatrck]

Seems like a good start.

[SaintPatrck]

🌱 Write tools are being added in #188 and #189. If leaving comments is ever desired as part of this process, we can add the necessary tool(s) to support that too.

[SaintPatrck]

Oops. Forgot about Claude's review. 🤦

The Critical and Major findings should be addressed before merging.