Skip to content

[PM-40640] Adjust error messages for Send policy enforcement - #8196

Open
mcamirault wants to merge 1 commit into
mainfrom
tools/pm-40640/adjust-send-policy-error-strings
Open

[PM-40640] Adjust error messages for Send policy enforcement#8196
mcamirault wants to merge 1 commit into
mainfrom
tools/pm-40640/adjust-send-policy-error-strings

Conversation

@mcamirault

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-40640

📔 Objective

This PR adjusts the error strings that are returned when Send policies are enforced so that all instances of "Enterprise Policy" are corrected to "Enterprise policy". No logic changes, only error messages.

@mcamirault
mcamirault requested a review from a team as a code owner August 12, 2026 17:14
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR changes "Enterprise Policy" to "Enterprise policy" in five BadRequestException messages in SendValidationService.ValidateUserCanSaveAsync and updates the matching assertions in SendValidationServiceTests and NonAnonymousSendCommandTests. No control flow, validation logic, or public contracts were altered. All Send policy messages in the file now use consistent casing, matching the already-lowercase messages for allowed Send types and deletion dates, and every test asserting on these strings was updated in step.

Code Review Details

No findings.

Notes considered and not raised as findings:

  • src/Core/Vault/Services/Implementations/CipherService.cs:151 and the PolicyRequirements/README.md examples still use "Enterprise Policy", but those are outside the Send policy scope stated in the PR objective.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.64%. Comparing base (8414547) to head (32abf39).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8196   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files        2373     2373           
  Lines      102846   102846           
  Branches     9328     9328           
=======================================
  Hits        65456    65456           
  Misses      35161    35161           
  Partials     2229     2229           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant