Skip to content

[PM-41871] Add Chrome extension beta to allowed passkey origins - #8197

Open
trmartin4 wants to merge 1 commit into
mainfrom
platform/add-chrome-beta-origin
Open

[PM-41871] Add Chrome extension beta to allowed passkey origins#8197
trmartin4 wants to merge 1 commit into
mainfrom
platform/add-chrome-beta-origin

Conversation

@trmartin4

@trmartin4 trmartin4 commented Aug 12, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-41871

📔 Objective

Adds the extension URL to the allowed origins for our Chrome store beta extension.

This will be used in the extension beta release being designed in bitwarden/clients#22191.

The extension identifier was pulled from https://chromewebstore.google.com/detail/bitwarden-password-manage/hccnnhgbibccigepcmlgppchkpfdophk.

@trmartin4 trmartin4 added the t:feature Change Type - Feature Development label Aug 12, 2026
@trmartin4 trmartin4 changed the title Add Chrome extension beta to allowed passkey origins. [PM-41871] Add Chrome extension beta to allowed passkey origins Aug 12, 2026
@trmartin4
trmartin4 marked this pull request as ready for review August 12, 2026 18:25
@trmartin4
trmartin4 requested review from a team and ike-kottlowski August 12, 2026 18:26
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single constant (Constants.BrowserExtensions.ChromeBetaId) for the Chrome Web Store beta extension and includes it in the default FIDO2/WebAuthn allowed origins set in AddWebAuthn. The change follows the existing pattern for the Chrome, Edge, and Opera extension IDs, and the new origin only applies when GlobalSettings.Fido2.Origins is not configured, so self-hosted overrides are unaffected. This is a trust-boundary addition, but the extension ID's provenance is documented in the PR description with a link to the Chrome Web Store listing. No correctness, security, or breaking-change issues found.

Code Review Details

No findings.

@trmartin4

Copy link
Copy Markdown
Member Author

Tagging team-auth-dev here because this affects passkey login, even though Auth doesn't technically own this file.

For context, see https://bitwarden.atlassian.net/wiki/spaces/~629553291648f20069618438/pages/3159064588/Beta+releases+at+Bitwarden (internal).

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.19%. Comparing base (643e3aa) to head (be7480c).

❗ There is a different number of reports uploaded between BASE (643e3aa) and HEAD (be7480c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (643e3aa) HEAD (be7480c)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8197      +/-   ##
==========================================
- Coverage   68.41%   63.19%   -5.22%     
==========================================
  Files        2380     2380              
  Lines      103679   103680       +1     
  Branches     9386     9386              
==========================================
- Hits        70931    65525    -5406     
- Misses      30420    35926    +5506     
+ Partials     2328     2229      -99     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ike-kottlowski ike-kottlowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of the Beta builds origin allows passkeys to be used in the upcoming beta releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants