Reject top-level version in package validation - #258
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AGENTS.mdrequires the skill version to live undermetadata.versionand forbids a top-levelversion. This layout was adopted after #41 becauseversionis not a supported top-level Agent Skills frontmatter field.The package validator currently rejects two disallowed top-level fields but omits
version. Adding a duplicate top-level version therefore still reports the package as valid.Change
Add
version:to the existing unsupported-field check. The check is anchored at the start of a line, so the valid indentedmetadata.versionremains allowed.Verification
main: a duplicate top-levelversionexits successfully.Remove unsupported YAML field: version.python scripts/validate-package.pynpx --yes skills@1.5.20 add . --listclaude plugin validate .git diff --checkDeveloped with AI assistance (Codex).