Point the sample-dash rule at §8 and check section references - #274
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
The voice section tells the reader their writing sample overrides "§6". Pattern 6 is forced triads. The dash rule is §8. Commit c2c6cad moved dashes from §6 to §8 to match the current Wikipedia article and updated the README number map, but this reference kept the old number. AGENTS.md asks for every §reference to move with a renumber, and no check enforced it. Update the reference. Then teach the validator to catch the next one: every §reference in SKILL.md must point at a pattern that exists, and the sample-dash rule must name the pattern whose heading covers dashes.
dajiaohuang
force-pushed
the
fix/sample-dash-section-reference
branch
from
September 11, 2026 10:30
f0ee0c0 to
30b8e07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273.
The fix
SKILL.md, Voice section. The sample-dash sentence named §6. Dashes are §8, because c2c6cad moved them there and updated the README number map but not this reference. One number changes.The check
scripts/validate-package.pygains two assertions:SKILL.mdmust point at a pattern that exists. A renumber that removes patterns can otherwise strand a reference outside the list.README.mdstays out of scope. Its §references sit in older version notes and use the old numbering on purpose.Checks run
All three from AGENTS.md, against
f0ee0c0:The new assertions fail on the unpatched file and pass on this one. Run against
HEAD'sSKILL.md:And against a reference pushed out of range:
On the version
This changes a cross-reference and a check, so the version stays at 3.0.0. The last three commits that touched prose (9862685, a62daa3, c2c6cad) shipped the same way. Say the word and I will add a README note and bump instead.
🤖 Generated with Claude Code