fix(acp): authenticate advertised ACP methods on spawn - #6366
Open
eikeon wants to merge 1 commit into
Open
Conversation
The live harness never sent ACP authenticate after initialize, even when the agent advertised cached_token or xai.api_key. Grok requires that before session/new; Goose and Claude advertise no such method and skip. Signed-off-by: Daniel Krech <eikeon@eikeon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialize, callauthenticatewhen the agent advertised a non-interactive method (cached_token, orxai.api_keywhenXAI_API_KEYis set)._meta.headlessso adapters that refuse a browser prompt (Grok Build) can complete auth.The live harness already had
buzz-acp authenticateas a one-shot CLI, but pool start and respawn never sent it. Agents that require auth beforesession/newthen fail the first turn (Grok logsAuth(AuthorizationRequired)and respawns).Do not authenticate again on every
session/new: that resets Grok's inner worker.Related
None found. Nearby PRs (
#4460workflow authorship,#4711Codex docs) are a different meaning of "authenticate".Verification
cargo test -p buzz-acp --lib headless_auth_method_testscargo clippy -p buzz-acp --all-targets -- -D warningscargo fmt -p buzz-acpjust test-unit+just desktop-tauri-clippy+just desktop-tauri-testbuzz-acpagainstgrok agent --always-approve stdiologsagent authenticated method_id=cached_tokenon spawn; first-channel@mentioncompletes without waiting on crash/respawn.