Enforce RuboCop in CI, and clear the 895 offenses first

[HamptonMakes]

RuboCop was installed but never enforced: .github/workflows/ci.yml had no lint step, so bin/rubocop had drifted to 895 offenses across 75 files. 882 were Layout/SpaceInsideArrayLiteralBrackets -- the repo uses rubocop-rails-omakase, which wants [ a, b ], and much of the codebase was written [a, b].

Two commits, deliberately split so the mechanical churn is skippable.

1. Autocorrect the debt

Every offense was flagged Safe Correctable, so this is bin/rubocop -a with nothing done by hand. bin/rubocop now reports 425 files inspected, no offenses detected.

Formatting only. Ignoring whitespace (git diff -w), the 75-file diff reduces to five files:

• three removed blank lines and one removed trailing hash comma
• one Style/RedundantReturn in CoPlan::WebPushSubscription#device_label

The return removal is the only one worth a look. It was on the method's last expression, directly in the method body rather than inside a block, so dropping the keyword is inert -- and the genuine early-return guard above it (return "Unknown browser" if ua.blank?) is untouched.

Files under db/migrate/ got reformatted too. That is safe: Rails tracks migrations by version number in schema_migrations, not by file checksum, so restyling an already-applied migration has no effect.

2. Enforce it

A lint job: checkout, setup-ruby, bin/rubocop. No database needed, and action SHAs are pinned to match the existing jobs. It is its own job rather than a step inside test, so a bracket-spacing nit cannot mask whether the suite passed.

One note on the db/schema.rb exclude

Worth flagging, because it is not what it looks like. db/schema.rb was already excluded -- rubocop-rails ships db/*schema.rb in its own AllCops: Exclude. Those 168 bracket offenses in schema.rb only ever appear if you pass the path explicitly; they were never part of the 895, and -a never touched the file. The entry I added is documentation for the next reader, not a fix.

The inherit_mode: merge above it, though, is load-bearing. A bare AllCops: Exclude: replaces the inherited list instead of appending to it, which would have quietly started linting bin/*, log/**, public/** and app/assets/**. Verified the whole config change is inert by diffing --list-target-files: 425 files before, 425 after, nothing entering or leaving the set.

If you would rather not carry a redundant exclude, the clean alternative is to drop both stanzas -- schema.rb stays excluded either way.

Verification

• bin/rubocop -- 425 files, 0 offenses
• bundle exec rspec -- 1658 examples, 0 failures, identical to the pre-change baseline on the same commit
• Both YAML files parse; jobs resolves to [lint, test, test-postgres]

Ruby 3.4.7 per .ruby-version, MySQL, against an isolated coplan_lint database.

🤖 Generated with Claude Code