Repository navigation
Time the replicant-ack budget from the fastest node (low priority) - #6272
Draft
emelialei88 wants to merge 2 commits into
Draft
emelialei88 wants to merge 2 commits into
emelialei88 wants to merge 2 commits into
Conversation
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
emelialei88
force-pushed
the
fix/first-ack-fastest
branch
from
September 30, 2026 18:56
16face9 to
fb2c940
Compare
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
emelialei88
force-pushed
the
fix/first-ack-fastest
branch
from
September 30, 2026 19:09
fb2c940 to
1fd6551
Compare
roborivers
approved these changes
Oct 1, 2026
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 The "Why" (Intent)
The replicant-ack wait was meant to time the other nodes from the fastest ack (the log even says "fastest node"). But it watched nodes one at a time, in list order, so a lagging node listed first got up to 1s of extra slack per pass. Which node got marked incoherent depended on list order.
🛠️ The "What" (Critical Changes)