Repository navigation
{186543087}: cdb2api: Don't retry on pooled connections to the failin… - #6306
Merged
Merged
Conversation
…g node When a query is dropped (e.g. by an incoherent node) or rejected, the retry asked sockpool for any connection under the tier's typestr, which can hand back another connection to the same node. Every attempt could land on that node until the retries ran out with "Maximum number of retries done". Set is_rejected on these retries, as legacy cdb2api does, so the retry connects to the chosen host instead. Also reset node_seq and hosts_connected only after reject handling, so a reject retry moves on to the next node rather than restarting the search. Add a test that fills sockpool with connections to one replicant, makes it incoherent, and checks that a query reaches another node within a few attempts. Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
mponomar
approved these changes
Oct 7, 2026
roborivers
approved these changes
Oct 7, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
comdb2sys_queueodh_generated [db unavailable at finish]
comdb2sys [db unavailable at finish] **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g node
When a query is dropped (e.g. by an incoherent node) or rejected, the retry asked sockpool for any connection under the tier's typestr, which can hand back another connection to the same node. Every attempt could land on that node until the retries ran out with "Maximum number of retries done".
Set is_rejected on these retries, as legacy cdb2api does, so the retry connects to the chosen host instead. Also reset node_seq and hosts_connected only after reject handling, so a reject retry moves on to the next node rather than restarting the search.
Add a test that fills sockpool with connections to one replicant, makes it incoherent, and checks that a query reaches another node within a few attempts.