frontend: fix usage of autopilot_data instead of autopilot

[Williangalvani]

Summary by Sourcery

Bug Fixes:

• Fix frame type parameter resolution by switching on the correct autopilot vehicle type property.

[cursor]

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="core/frontend/src/components/vehiclesetup/configuration/ArdupilotVehicleBodySetup.vue" line_range="68" />
<code_context>
     },
     frame_type_parameter(): Parameter | undefined {
-      switch (autopilot_data.vehicle_type) {
+      switch (autopilot.vehicle_type) {
         case 'Submarine':
         case 'Surface Boat':
</code_context>
<issue_to_address>
**issue (bug_risk):** Potentially inconsistent use of `autopilot` vs `autopilot_data` when switching on `vehicle_type`.

In other parts of this component, parameters come from `autopilot_data`, and this line previously used `autopilot_data.vehicle_type`. If `autopilot` and `autopilot_data` can differ, using `autopilot.vehicle_type` here might cause the frame type to no longer match the parameter source. Please confirm `autopilot.vehicle_type` is the intended authoritative value, or standardise on one of these objects for consistency.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

Automated PR Review

0. Summary

• Verdict: LGTM

One-line bug fix in core/frontend/src/components/vehiclesetup/configuration/ArdupilotVehicleBodySetup.vue:68: the frame_type_parameter computed was reading autopilot_data.vehicle_type, but vehicle_type is defined on the autopilot_manager store (imported here as autopilot), not the autopilot parameter store (imported as autopilot_data). The old code would always fall into the default branch and return undefined, hiding the Frame Subtype selector. Confirmed by grep that this was the only remaining stale reference under core/frontend/, and matches the existing usage pattern in core/frontend/src/store/autopilot.ts which also reads autopilot_manager.vehicle_type.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.