Skip to content

fix: make data validation commands reliable - #94

Open
vincenzofamoso wants to merge 1 commit into
bnb-chain:mainfrom
vincenzofamoso:fix/data-validation-commands
Open

vincenzofamoso wants to merge 1 commit into
bnb-chain:mainfrom
vincenzofamoso:fix/data-validation-commands

Conversation

@vincenzofamoso

@vincenzofamoso vincenzofamoso commented Aug 13, 2026 •

Copy link
Copy Markdown

npm run lint currently starts jsonlint without a file, which makes it read
empty stdin and fail. This points it at data.json and keeps successful output
quiet.

The duplicate check also ignored groupTitle, so the same tool appearing in
two different subcategories was reported as a duplicate. Including the group
leaves only the actual duplicate Envio entry, which is already handled by #92.

Testing

  • npm run lint
  • npm run validate

@hashdit-bot

hashdit-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

Pull Request Review

This PR makes the Node.js data-validation workflow more reliable by linting data.json directly and suppressing successful jsonlint output. It also scopes duplicate detection by category, group title, and tool name, reducing false-positive warnings across different subcategories.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant