doc: landing page code cleanup#509
Conversation
|
An automated preview of the documentation is available at https://509.graph.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-06-22 08:30:25 UTC |
|
Compiler-warning counts vs
|
|
PR titles, as with git commit messages, should say explain what and why. The backstory (feedback from person X) belongs in the details. |
jeremy-murphy
left a comment
There was a problem hiding this comment.
It's fine, apart from the awkward choice of variable name that I highlighted.
I'm not sure why the particular code changes are important, though?
| constexpr int num_vertices = 20; | ||
| Graph g(edges.begin(), edges.end(), num_vertices); |
There was a problem hiding this comment.
num_vertices is the same name as the function in Boost.Graph, so creating a variable with that name can be awkward for ADL. If the variable only gets used once, I would consider leaving it out altogether.
| constexpr int num_vertices = 20; | |
| Graph g(edges.begin(), edges.end(), num_vertices); | |
| Graph g(edges.begin(), edges.end(), 20); |
There was a problem hiding this comment.
I will rename it nb_vertices then. We can't leave it out, as Andrzej and others regularly get confused about what this number in the parameters list is: so it's either a named variable or another comment. I prefer actual code over comments :)
Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
Motivation
See recent Boost Mailing List poll.
Testing
Checklist
b2in thetest/directory).