Replace the deprecated std::random_shuffle with std::shuffle#513
Open
Becheler wants to merge 1 commit into
Open
Replace the deprecated std::random_shuffle with std::shuffle#513Becheler wants to merge 1 commit into
std::random_shuffle with std::shuffle#513Becheler wants to merge 1 commit into
Conversation
|
Compiler-warning counts vs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clears
-Wdeprecated-declarationson both clang and gcc : refer #496Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
Replace the deprecated
std::random_shuffle(removed in C++17) withstd::shuffle(avaiable in C++14)isomorphism.cppandvf2_sub_graph_iso_test.cpp: dropped theBOOST_NO_CXX98_RANDOM_SHUFFLEguard, now alwaysstd::shuffle(..., gen), and removed the now-unusedrand_fun.fibonacci_heap.cpp: same guard collapse tostd::shuffle(..., gen).Motivation
Refs #496
Testing
Checklist
b2in thetest/directory).