Add standalone headers tests - #517
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #517 +/- ##
========================================
Coverage 99.17% 99.17%
========================================
Files 146 146
Lines 7405 7405
========================================
Hits 7344 7344
Misses 61 61 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Dependencies are linked explicitly without linking with other targets to prevent masking missing includes. However, it seems that all public headers were already self-contained. |
| # file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt) | ||
| # | ||
|
|
||
| add_library( |
There was a problem hiding this comment.
- I'd make this an executable
- I'd link it to
Boost::mysql, so you don't need to repeat any of the include directories or link libraries
|
Thanks! I truly appreciate your patience and guidance. But why CMake build should be an executable? I tried to make target OBJECT library previously, but it didn't link against dependencies and STATIC worked just fine. And in B2 build we just trying to compile all files to see if there's compile errors without building an executable. |
|
CMake build also need to link Boost::pfr, because |
|
Yes you are right about the executable comment, I was a bit picky. Static library should work fine too. Pfr is supposed to be an optional dependency that you get only if you include that optional header, so it is expected to need the extra link libraries dependency. |
close #479
Added standalone compile tests for all public headers as new build target except src.hpp, because it already compiled separetely in other test target.