Story 2551: Improve Library Subpage Layout - #2556
Open
julhoang wants to merge 8 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
julhoang
marked this pull request as ready for review
July 29, 2026 00:11
julhoang
force-pushed
the
feat/library-subpage-content
branch
from
August 4, 2026 20:20
3b9143a to
3c2ba00
Compare
julhoang
force-pushed
the
julia/improve-library-subpage-layout
branch
from
August 4, 2026 20:30
b71d160 to
7819908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2551
Summary & Context
This PR improves the grid layout of the Library subpage by capping the height of each card body and making the scroll region the card body rather than the text area inside it. Also settles card strokes on one neutral colour across themes and dark mode.
Changes
Card body height and scroll region
overflow-y: autoto each card so everything below the title scrolls as one region, leaving the title, divider and CTA fixed[data-ml-block]Alpine wrapper the max-width override list didn't reachBenchmark Cards
Card strokes
--color-stroke-weak(code-block.css,card-group.css,stats.css); removes the redundanthtml.darkrules and the unused--code-block-bordertokensv3-examples-section.css; mailing list badge text switched to--color-text-on-accentTokens and docs
--letter-spacing-tightreplaces hardcoded values instats.css;release-detail.css, markdown cards with a CTA on user profiles, and the components demo page[data-ml-block]staying on the Alpine wrapperPeer Testing Review
website-adocdemo content into a library, you can visit Admin Panel to update the content to test how the UI respond when there are more or less content (and how the card will handle overflow)Screenshots
--stroke-weak(instead of yellow, green, etc) to correctly match FigmaSelf-review Checklist
Frontend