Skip to content

Story 2551: Improve Library Subpage Layout - #2556

Open
julhoang wants to merge 8 commits into
feat/library-subpage-contentfrom
julia/improve-library-subpage-layout
Open

Story 2551: Improve Library Subpage Layout#2556
julhoang wants to merge 8 commits into
feat/library-subpage-contentfrom
julia/improve-library-subpage-layout

Conversation

@julhoang

@julhoang julhoang commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Issue: #2551

⚠️ This PR is branched off from Story 2430: Library Subpage Integration ⚠️

Summary & Context

This PR improves the grid layout of the Library subpage by capping the height of each card body and making the scroll region the card body rather than the text area inside it. Also settles card strokes on one neutral colour across themes and dark mode.

Changes

Card body height and scroll region

  • Add a body wrapper with overflow-y: auto to each card so everything below the title scrolls as one region, leaving the title, divider and CTA fixed
  • Cap each body: About 450px, Contributors 440px, Benchmarks 362px, Designed for 245px, Install 214px, Freeform 143px
  • Keep the About and Install code blocks at full height so they don't become nested scrollers
  • Fix the mailing list card so it fills its column – its root sits under an extra [data-ml-block] Alpine wrapper the max-width override list didn't reach

Benchmark Cards

  • Add more colored variants to the V3 Demo page

Card strokes

  • Every themed card now uses the neutral --color-stroke-weak (code-block.css, card-group.css, stats.css); removes the redundant html.dark rules and the unused --code-block-border tokens
  • Dark mode: transparent example box and TOC backgrounds in v3-examples-section.css; mailing list badge text switched to --color-text-on-accent

Tokens and docs

  • Top-of-file docs added to four CSS files
  • --letter-spacing-tight replaces hardcoded values in stats.css;

‼️ Risks & Considerations ‼️

  • The four card components are shared, so this reaches the Documentation card, the Release notes card in release-detail.css, markdown cards with a CTA on user profiles, and the components demo page
  • The mailing list override depends on [data-ml-block] staying on the Alpine wrapper

Peer Testing Review

  1. Please follow the set up as in Story 2430: Library Subpage Integration
  2. Once loaded the website-adoc demo content into a library, you can visit Admin Panel to update the content to test how the UI respond when there are more or less content (and how the card will handle overflow)
Screenshot 2026-07-28 at 5 03 20 PM

Screenshots

Before After Notes
page before page after Full page comparison, main difference is with the new max-height restrictions
Screenshot 2026-07-28 at 4 51 52 PM image Text color token used in the badge was updated so that the dark mode is correctly applied. This component is also now full-width on mobile view.
Screenshot 2026-07-28 at 4 53 20 PM Screenshot 2026-07-28 at 4 52 47 PM For all of the cards that have accent colors, the border is now --stroke-weak (instead of yellow, green, etc) to correctly match Figma

Self-review Checklist

  • Tag at least one team member from each team to review this PR
  • Link this PR to the related GitHub Project ticket

Frontend

  • UI implementation matches Figma design
  • Tested in light and dark mode
  • Responsive / mobile verified
  • Accessibility checked (keyboard navigation, etc.)
  • Ensure design tokens are used for colors, spacing, typography, etc. – No hardcoded values
  • Test without JavaScript (if applicable)
  • No console errors or warnings

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b0769467-c7ae-4a9d-9ddf-1f60c3ad83c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julia/improve-library-subpage-layout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@julhoang
julhoang marked this pull request as ready for review July 29, 2026 00:11
@julhoang julhoang linked an issue Jul 29, 2026 that may be closed by this pull request
@julhoang
julhoang force-pushed the feat/library-subpage-content branch from 3b9143a to 3c2ba00 Compare August 4, 2026 20:20
@julhoang
julhoang force-pushed the julia/improve-library-subpage-layout branch from b71d160 to 7819908 Compare August 4, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webpage UI: Improve Grid Layout on Libraries Subpage

1 participant