Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new ephemeral test-basic subcommand to the bcvk tool, which serves as a smoke test by booting an ephemeral VM and verifying its health using systemctl is-system-running. The update includes the command logic, a corresponding integration test, and comprehensive documentation. Feedback was provided to improve the robustness of the health check by adding the --wait flag to the systemctl command and to remove an unnecessary -- separator from the SSH arguments to ensure consistency with existing command-line behavior.
Add `bcvk ephemeral test-basic <image>` which boots an ephemeral VM and verifies systemd reached a healthy state via `systemctl is-system-running`. This provides a quick smoke test for bootc container images. Assisted-by: Claude Code (Opus 4.6) Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Author
|
|
cgwalters
reviewed
Apr 7, 2026
cgwalters
left a comment
cgwalters
left a comment
Collaborator
There was a problem hiding this comment.
I know I suggested this as a kind of offhand comment, but a few things here.
- Commands we expose should generally also appear as varlink; maybe going forward we actually try to have the CLI be sugar around varlink just to force this
- If we're making "is system healthy" commands probably it should apply to libvirt too?
- Bigger picture...I would really like bcvk to help be an awesome component of testing frameworks - but without growing into a complete framework itself ideally. But in that vein we need to ask how to make this extensible
Combining the above...one thing I was thinking about here and have some code towards in an unpushed commit is - what if we bridged e.g. the dbus socket or systemd dbus/varlink itself? Worth investigating because then it becomes way more flexible, we aren't just hardcoding one systemd API call.
Collaborator
cgwalters
added
agent/code
Collaborator
|
Blah, our AW deployment only works on branches starting with agent/. xref #356 |
cgwalters-bot
added a commit
to cgwalters-forge/bcvk
that referenced
this pull request
Sep 28, 2026
A quick "does this image boot healthy" check is what most CI consumers of bcvk end up writing by hand with run-ssh, so give it a name: `bcvk ephemeral test-basic IMAGE` is shorthand for run-ssh with `systemctl is-system-running --wait`, which also lists the failed units when the system comes up degraded, and exits non-zero unless it reaches "running". Now that bcvk masks bootloader-update.service, stock images reach "running" in an ephemeral VM, so a degraded state really means something is wrong with the image. Rather than duplicating run-ssh's VM lifecycle and SSH handling, it re-executes bcvk as run-ssh with the same arguments, so it can't drift from it. The options are still declared (flattened from `ephemeral run`) so they are validated up front and show up in --help and the man page. Based on bootc-dev#244 by Xiaofeng Wang and the automated follow-up bootc-dev#357, reworked per review there. Closes: bootc-dev#356 Generated-by: AI
cgwalters-bot
added a commit
to cgwalters-forge/bcvk
that referenced
this pull request
Sep 30, 2026
A quick "does this image boot healthy" check is what most CI consumers of bcvk end up writing by hand with run-ssh, so give it a name: `bcvk ephemeral test-basic IMAGE` is shorthand for run-ssh with `systemctl is-system-running --wait`, which also lists the failed units when the system comes up degraded, and exits non-zero unless it reaches "running". Now that bcvk masks bootloader-update.service, stock images reach "running" in an ephemeral VM, so a degraded state really means something is wrong with the image. Rather than duplicating run-ssh's VM lifecycle and SSH handling, it re-executes bcvk as run-ssh with the same arguments, so it can't drift from it. The options are still declared (flattened from `ephemeral run`) so they are validated up front and show up in --help and the man page. Based on bootc-dev#244 by Xiaofeng Wang and the automated follow-up bootc-dev#357, reworked per review there. Closes: bootc-dev#356 Generated-by: AI
cgwalters-bot
added a commit
to cgwalters-forge/bcvk
that referenced
this pull request
Sep 30, 2026
A quick "does this image boot healthy" check is what most CI consumers of bcvk end up writing by hand with run-ssh, so give it a name: `bcvk ephemeral test-basic IMAGE` is shorthand for run-ssh with `systemctl is-system-running --wait`, which also lists the failed units when the system comes up degraded, and exits non-zero unless it reaches "running". Now that bcvk masks bootloader-update.service, stock images reach "running" in an ephemeral VM, so a degraded state really means something is wrong with the image. Rather than duplicating run-ssh's VM lifecycle and SSH handling, it re-executes bcvk as run-ssh with the same arguments, so it can't drift from it. The options are still declared (flattened from `ephemeral run`) so they are validated up front and show up in --help and the man page. Based on bootc-dev#244 by Xiaofeng Wang and the automated follow-up bootc-dev#357, reworked per review there. Closes: bootc-dev#356 Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
pushed a commit
that referenced
this pull request
Oct 1, 2026
A quick "does this image boot healthy" check is what most CI consumers of bcvk end up writing by hand with run-ssh, so give it a name: `bcvk ephemeral test-basic IMAGE` is shorthand for run-ssh with `systemctl is-system-running --wait`, which also lists the failed units when the system comes up degraded, and exits non-zero unless it reaches "running". Now that bcvk masks bootloader-update.service, stock images reach "running" in an ephemeral VM, so a degraded state really means something is wrong with the image. Rather than duplicating run-ssh's VM lifecycle and SSH handling, it re-executes bcvk as run-ssh with the same arguments, so it can't drift from it. The options are still declared (flattened from `ephemeral run`) so they are validated up front and show up in --help and the man page. Based on #244 by Xiaofeng Wang and the automated follow-up #357, reworked per review there. Closes: #356 Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
Collaborator
|
Thanks so much for starting this! This ended up being rebased and tweaked a bit in #393 Which now that I look basically ignored my comments on #244 (review) so...sorry we probably could have just landed what was here. I'll file another issue for followups! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
bcvk ephemeral test-basic <image>which boots an ephemeral VM and verifies systemd reached a healthy state viasystemctl is-system-running. This provides a quick smoke test for bootc container images.Assisted-by: Claude Code (Opus 4.6)