utils: Quote empty arguments in command displays - #2533
Merged
cgwalters merged 1 commit intoOct 3, 2026
Merged
Conversation
Empty arguments currently disappear from the shell-style command display. Quote them so copying the displayed command preserves its argument list. Signed-off-by: Natsu <139412824+ddy314@users.noreply.github.com>
ddy314
force-pushed
the
fix/quote-empty-command-arguments
branch
from
October 3, 2026 06:31
fee840b to
3d1dc62
Compare
ddy314
marked this pull request as ready for review
October 3, 2026 06:31
cgwalters
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty string arguments disappear from the shell-style command display. Quote them as
''so copying a displayed command preserves its argument list. This affects display only; command execution already passes the original arguments.Validation:
cargo fmt --all -- --check,cargo test -p bootc-internal-utils --locked(21 passed), andcargo clippy -p bootc-internal-utils --all-targets --locked -- -D warnings. The empty-string regression failed before the fix; the tests check exact output and shell-token round trips.