Update github cli signing key - #267
Merged
gursewak1997 merged 1 commit intoSep 21, 2026
Merged
Conversation
See cli/cli#13118 for details Signed-off-by: John Eckersberg <dev@eckersberg.com>
This was referenced Sep 21, 2026
gursewak1997
approved these changes
Sep 21, 2026
cgwalters
reviewed
Sep 21, 2026
| enabled=1 | ||
| gpgcheck=1 | ||
| gpgkey=https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x23F3D4EA75716059 | ||
| gpgkey=https://cli.github.com/packages/githubcli-archive-keyring.asc |
Contributor
There was a problem hiding this comment.
Nothing to change here but in practice now this is basically just chaining security of TLS for what it's worth...like in the general case in theory what we should do here is have a set of keys in a trust root we manage.
But we already rely on TLS for many other things anyways.
An alternative actually is a much-reduced set of TLS trust roots than the default ca-certificates for the build process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See cli/cli#13118 for details
Signed-off-by: John Eckersberg dev@eckersberg.com