packages: add nvidia-dra-driver-gpu - #1035
Merged
Merged
Conversation
arnaldo2792
reviewed
Sep 11, 2026
maherthomsi
force-pushed
the
dra-changes
branch
from
September 11, 2026 06:59
41e32c2 to
1e8bb1e
Compare
Contributor
Author
|
Added settings-sdk changes to this PR |
maherthomsi
force-pushed
the
dra-changes
branch
4 times, most recently
from
September 11, 2026 22:06
63c65b5 to
5dc5941
Compare
vigh-m
reviewed
Sep 11, 2026
vigh-m
reviewed
Sep 11, 2026
maherthomsi
force-pushed
the
dra-changes
branch
from
September 11, 2026 23:12
5dc5941 to
fb76dcc
Compare
Contributor
Author
|
Addresses review feedback on the nvidia-dra-driver-gpu package:
|
arnaldo2792
reviewed
Sep 11, 2026
maherthomsi
force-pushed
the
dra-changes
branch
2 times, most recently
from
September 12, 2026 01:02
93457dd to
1919b69
Compare
vigh-m
approved these changes
Sep 14, 2026
piyush-jena
previously approved these changes
Sep 14, 2026
maherthomsi
force-pushed
the
dra-changes
branch
4 times, most recently
from
September 16, 2026 23:40
41ee794 to
7de8784
Compare
Add the nvidia-dra-driver-gpu package, which builds the NVIDIA GPU DRA driver (gpu-kubelet-plugin) and installs it as a host systemd service. Include it in the bottlerocket-core-kit workspace and kit manifest. Signed-off-by: Maher Homsi <maherhom@amazon.com>
Signed-off-by: Maher Homsi <maherhom@amazon.com>
maherthomsi
force-pushed
the
dra-changes
branch
from
September 17, 2026 16:39
7de8784 to
58be3b3
Compare
piyush-jena
self-requested a review
September 17, 2026 17:54
piyush-jena
dismissed
their stale review
September 17, 2026 17:55
new changes pushed. I will review them.
Contributor
|
Looks good to me! I had this design in mind which I think should work: The design I described comes with a very small boot time penalty but imo is cleaner. Your design works too. |
vigh-m
approved these changes
Sep 17, 2026
piyush-jena
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds the nvidia-dra-driver-gpu package, which builds the NVIDIA GPU DRA driver (gpu-kubelet-plugin) and installs it as a host systemd service. The package is added to the bottlerocket-core-kit workspace and included in the kit manifest so it is available to consuming variants.
Bump settings sdk for this change to include bottlerocket-os/bottlerocket-settings-sdk#148
The DRA driver (
nvidia-dra-driver-gpu.service) and the kubernetes device plugin (nvidia-k8s-device-plugin.service) both allocate the same GPUs, so only one runs at a time. This is enforced without a systemdConflicts=: the DRA unit gates onConditionFileNotEmpty=/etc/nvidia-dra-driver-gpu/enabled, and the marker is renderedrun(non-empty) only when DRA is enabled and the device plugin is disabled. DRA is therefore opt-in and off by default.Both settings present
kubelet-dra-drivers.nvidia.enabledkubelet-device-plugins.nvidia.enablednvidia.com/gpu)Settings extension not present (failure to adopt the DRA settings API)
kubelet-dra-driversextension absentkubelet-dra-driversextension absentWhat "unset" means per setting
kubelet-dra-drivers.nvidia.enableddefault "false"; shipped default isfalse)kubelet-device-plugins.nvidia.enableddefault "true"; classic behavior)Out-of-the-box default (both unset): DRA off, device plugin running.
Guarantees: exactly one GPU publisher at any time; the device plugin wins when both are enabled (deterministic, no boot-time race); with no settings API the DRA driver stays off
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.