Pytest integrated#3331
Conversation
matching either to a file named `test_foo.py`.
Native configuration is x86_64-pc-linux-gnu
=== tests ===
Schedule of variations:
unix
Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
=== Summary === to in CMakeLists.txt
so that the `input` directory is found.
so that the `test` directory is found.
so that the `data` directory is found.
Fails due to missing file `grid.fci.nc`.
Change directory to exe location prior to attempting to run it.
Change directory to exe location prior to attempting to run it.
Change directory to exe location prior to attempting to run it.
This is only useful if run independently, which is not possible anymore
dschwoerer
left a comment
dschwoerer
left a comment
There was a problem hiding this comment.
I did not see any major regressions, there are several tests where the output on failure is worse than it used to, because it already fails on the first failure.
I have pushed a few fixes. That was easier then turning them into comments. Feel free to revert, if they seem / are wrong.
One thing that is worrying me, ist that something like this:
@pytest.mark.parametrize("nproc", [1, 2, 3, 4]) will cause race conditions - because they run the simulations in the same folder.
I guess that applies to most parametrisation - they will cause race conditions if the simulation is in the same folder.
I am fine with merging it now, if that will be resolved soonish, so that we do not need to check all the tests again. But that means we may not be testing what we want to test, and it might also fail, because the dump files are still written for a different simulation.
This reverts commit 3e91960. We do not call MPI_finalize. This make mpirun unhappy.
There's a fixture |
|
Amazing ❤️ |
4 participants
No description provided.